feedback for expanse scripts, moved {env} {res} {custom}, removed the source ./bashrc since that can be handled in {custom}
#834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchen6727
merged commit 709eaf1
into
suny-downstate-medical-center:development
4 of 5 checks passed
pgleeson
added a commit
that referenced
this pull request
Dec 20, 2024
* development: (49 commits) Extracellular stimulation via .mod small correction in plotter.py Conflict diversity and LFP Conflict between diversity and LFP for unit tests, rolled back to 3.12 so far test with python 3.9-3.13 drop python 3.7 for unit-tests plotCSD: time slicing on pre-loaded data (credit: Nikita Novikov) extracellular stimulation quick fix to `update` method that allows for working with lists. (#837) d/w expanse setup, moved {env} {res} {custom} (#834) hot fix (submits.py) (#833) code adjustments to internal sim.clearAll(), added sim.close() (#832) file cleanup, slurm scripts and timeout added to batchtools submit templates (#831) updated upload instructions to exclude downtime fixed sbi deprecation error. fixes in docs formatting minor correction to CHANGES.md VERSION 1.0.7 Revert "Exlude tests from discovery / installation" - due to issue that has emerged with spack installation (EBRAINS platform). Will re-visit later.. merge of batchtools into the development repository. (#829) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feedback for expanse scripts, moved {env} {res} {custom}, removed the
source ./bashrcsince that can be handled in {custom}also note-- new test for 3.7 failing d/t external error "functools" import