Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register valid values with a.soar.Product attribute #36

Merged
merged 5 commits into from
Aug 29, 2022
Merged

Conversation

dstansby
Copy link
Member

Fixes #33. I still need to work out how to add info from the FITS table to this.

@ebuchlin
Copy link

Yes, fits_dataset exists in SOAR TAP tables, but is missing some information present in cdf_dataset.

@dstansby
Copy link
Member Author

I just took another look at this, and as you say there's not as much info in fits_dataset, in particular there doesn't seem to be a column we can use as the dataset description:
Screenshot 2022-08-29 at 16 33 08

For now I might just scrape the dataset names without a description, as that's still an improvement.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Base: 97.44% // Head: 97.63% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (05350d9) compared to base (9e657a2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   97.44%   97.63%   +0.18%     
==========================================
  Files           4        4              
  Lines         196      211      +15     
==========================================
+ Hits          191      206      +15     
  Misses          5        5              
Impacted Files Coverage Δ
sunpy_soar/client.py 100.00% <100.00%> (ø)
sunpy_soar/tests/test_sunpy_soar.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dstansby dstansby marked this pull request as ready for review August 29, 2022 17:47
@dstansby dstansby requested a review from a team August 29, 2022 17:47
@nabobalis
Copy link
Contributor

Worth a unit test to check at least one product attr was registered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a.soar.Product information
4 participants