Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates gem dependencies and fixes mimetime fixture failing test #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryanfelton
Copy link

@ryanfelton ryanfelton commented Aug 18, 2021

Fixes #3

@summera
Copy link
Owner

summera commented Aug 29, 2021

@ryanfelton thanks for the PR! I've fixed the bundler dependency issue in #5 by removing it from the gemspec. I've also committed the Gemfile.lock to source control since that's best practice.

Would you mind rebasing this branch with a focus on fixing the failing tests? I do see that there are some warnings being output when running the tests. I can fix those in a separate PR or if you're interested in tackling that as well, let me know! I don't use this gem anymore, so if you're actively using it, you're probably in a better position than I am to ensure it's working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency issues with Ruby on Rails 6.1.x
2 participants