Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with none existing webspace in requestAnalyzer in asnyc processes #710

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Nov 26, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs after upgrade #635 make other project fail
License MIT

What's in this PR?

Fix issue with none existing webspace in requestAnalyzer in asnyc processes.

Why?

RequestAnalyzer may not be set in async messenger processes.

@alexander-schranz alexander-schranz added the bug Error or unexpected behavior of already existing functionality label Nov 26, 2024
@@ -45,6 +45,7 @@
'phpdoc_to_comment' => [
'ignored_tags' => ['todo', 'var', 'see', 'phpstan-ignore-next-line'],
],
'trailing_comma_in_multiline' => false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still support 7.3 on this branch so no trailing comma for methods

@Prokyonn Prokyonn enabled auto-merge (squash) November 26, 2024 08:16
@Prokyonn Prokyonn merged commit 5c8226f into sulu:2.6 Nov 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error or unexpected behavior of already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants