Index correct ghost content when deleting the locale of an article #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
hotfix/index-correct-ghost-content
branch
from
080a06f to
61ac120
Compare
wachterjohannes
force-pushed
the
hotfix/index-correct-ghost-content
branch
2 times, most recently
from
b47dbb2 to
665a5ef
Compare
wachterjohannes
force-pushed
the
hotfix/index-correct-ghost-content
branch
6 times, most recently
from
fd1a97a to
12e25e9
Compare
wachterjohannes
force-pushed
the
hotfix/index-correct-ghost-content
branch
from
12e25e9 to
073e7e4
Compare
wachterjohannes
force-pushed
the
hotfix/index-correct-ghost-content
branch
from
073e7e4 to
02e3485
Compare
chirimoya
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
When deleting a locale of an article the behaviour was wrong which locale is the "ghosted" locale. This should be fixed with this PR.
This PR uses now an existing one. If the default one is available this one will be used else another one will be used.
Additionally this PR fixes the problem when a locale was remove which is the ghosted locale of another page.
Why?
Without this fix ALWAYS the default locale was the ghosted locale. Also if this locale was removed or another one but the default one was not created.
To Do