[DO NOT MERGE] Rename "Library ID" to "University ID" #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgiarlo
force-pushed
the
university-id-SearchWorks#3773
branch
from
791f25f
to
8d06c36
Compare
mjgiarlo
force-pushed
the
university-id-SearchWorks#3773
branch
from
8d06c36
to
672c547
Compare
mjgiarlo
changed the title
mjgiarlo
force-pushed
the
university-id-SearchWorks#3773
branch
from
4036265
to
9d8baca
Compare
Connects to sul-dlss/SearchWorks#3773 This commit helps us move the access portfolio beyond using library barcode numbers, leaning instead on the university-assigned and -managed "university ID."
mjgiarlo
force-pushed
the
university-id-SearchWorks#3773
branch
from
9d8baca
to
a091007
Compare
|
@corylown Do you know if this is still valuable to keep around or was it superseded? |
|
@mjgiarlo it's hard for me to tell. Looks like we switched to university id here https://github.com/sul-dlss/sul-requests/pull/2133/files. There's also been quite a lot of change in sul-requests since this PR was opened. There's some cleanup here that we might still want, but I'm not sure when anyone will have a chance to revive this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to sul-dlss/SearchWorks#3773
This commit helps us move the access portfolio beyond using library barcode numbers, leaning instead on the university-assigned and -managed "university ID."