Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

[fix] Event UpdateDirty didn't fire when remounting #76

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

AsPulse
Copy link
Member

@AsPulse AsPulse commented Oct 12, 2023

  • Add resetDirty
  • Use resetdirty instead

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2c04715) 79.32% compared to head (00027c3) 79.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   79.32%   79.47%   +0.14%     
==========================================
  Files          17       17              
  Lines         416      419       +3     
  Branches       82       82              
==========================================
+ Hits          330      333       +3     
  Misses         85       85              
  Partials        1        1              
Files Coverage Δ
packages/core/src/component/sugar/dirty.ts 100.00% <100.00%> (ø)
packages/core/src/component/sugar/maple/array.ts 78.04% <100.00%> (ø)
packages/core/src/component/sugar/maple/index.ts 89.15% <100.00%> (ø)
packages/core/src/component/sugar/sync/ref.ts 100.00% <100.00%> (ø)
packages/core/src/component/sugar/constant.ts 21.42% <50.00%> (ø)
packages/core/src/component/sugar/sync/state.ts 20.83% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Bundle Size Summary

Base branch HEAD branch Diff
CommonJS 11.84 kB 11.93 kB + 0.09 kB
ES Module 11.63 kB 11.71 kB + 0.09 kB
Package 32.56 kB 32.73 kB + 0.17 kB

@AsPulse AsPulse merged commit ace2f67 into main Oct 12, 2023
7 checks passed
@AsPulse AsPulse deleted the fix/updatedirty-not-fired-when-remounting branch October 12, 2023 06:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant