Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #33: chat_bubble_widget #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

duong2417
Copy link
Contributor

Fix issue #33

  1. Use "CachedNetworkImage" (from the cached_network_image library) instead of "ImageNetwork":

    • Utilize caching to store images loaded from URLs. Once an image is loaded, it won't need to be fetched from the network again but will instead be retrieved from the cache.
    • Automatically manage cache storage and deletion.
    • Ideal for applications that display multiple or recurring images, saving network data and improving display speed.
  2. ChatBubble:

    • Extract methods for better code readability.
    • Use AutomaticKeepAliveClientMixin: This mixin helps widgets retain their state when they go off-screen, avoiding unnecessary rebuilds.

@duong2417 duong2417 requested a review from suesitran as a code owner November 16, 2024 05:42
@duong2417 duong2417 changed the title fix chat_bubble_widget: change to stf, extract methods and mixin AutomaticKeepAliveClientMixin Fix issue #33: chat_bubble_widget: change to stf, extract methods and mixin AutomaticKeepAliveClientMixin Nov 18, 2024
@duong2417 duong2417 changed the title Fix issue #33: chat_bubble_widget: change to stf, extract methods and mixin AutomaticKeepAliveClientMixin Fix issue #33: chat_bubble_widget Nov 18, 2024
@thenartus
Copy link

We will need CORS setting off we wanna use CachedNetworkImage

@suesitran do we have time to setup cors?

@suesitran
Copy link
Owner

suesitran commented Nov 18, 2024

this is a good PR, will merge when I finish CORS setting, but need @duong2417 to fix the build for web, GitHub Action failed so thi can't be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants