Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: encode proof solidity #836

Merged
merged 4 commits into from
May 30, 2024
Merged

feat: encode proof solidity #836

merged 4 commits into from
May 30, 2024

Conversation

ratankaliani
Copy link
Member

@ratankaliani ratankaliani commented May 30, 2024 •
edited
Loading

Encode the proof into the expected Solidity verifier format using MarshalSolidity. Previously, when trying to use the encoded_proof from the PlonkBn254Proof, we would get the proof bytes were too large, as we were using the raw_proof.

Also, removes the test_prove_e2e tests as they're redundant given the test_prove_e2e_plonk tests.

@ratankaliani ratankaliani changed the base branch from main to dev May 30, 2024 01:26
@ratankaliani ratankaliani enabled auto-merge May 30, 2024 01:27
@ratankaliani ratankaliani merged commit e83a5bd into dev May 30, 2024
6 checks passed
@ratankaliani ratankaliani deleted the ratan/encode-proof-solidity branch May 30, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctian1 ctian1 ctian1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ratankaliani @ctian1