Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update release workflow #777

Merged
merged 4 commits into from
May 21, 2024
Merged

fix: update release workflow #777

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d55f74c
feat: add release workflow
ratankaliani May 21, 2024
88622d3
change sp1up version to main
ratankaliani May 21, 2024
e465b4a
fix
ratankaliani May 21, 2024
97b1557
clean
ratankaliani May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,15 @@ jobs:
with:
key: ${{ matrix.target }}
cache-on-failure: true

- name: Install go
uses: actions/setup-go@v5
with:
go-version: '^1.22.1'

- name: Check go installation
run: |
go version

- name: Set up git private repo access
run: |
Expand Down
8 changes: 4 additions & 4 deletions sp1up/sp1up
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@ main() {

# Install by downloading binaries
if [[ "$SP1UP_REPO" == "succinctlabs/sp1" && -z "$SP1UP_BRANCH" && -z "$SP1UP_COMMIT" ]]; then
SP1UP_VERSION=${SP1UP_VERSION:-nightly}
SP1UP_VERSION=${SP1UP_VERSION:-main}
SP1UP_TAG=$SP1UP_VERSION

# Normalize versions (handle channels, versions without v prefix
if [[ "$SP1UP_VERSION" =~ ^nightly ]]; then
SP1UP_VERSION="nightly"
# Normalize versions (handle channels, versions without v prefix)
if [[ "$SP1UP_VERSION" == "main" ]]; then
SP1UP_VERSION="main"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this fully makes sense?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agreed, will clean this up. Before it just used the latest tag that started with nightly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: If we change back to nightly releases @jtguibas we'll need to re-add this.

elif [[ "$SP1UP_VERSION" == [[:digit:]]* ]]; then
# Add v prefix
SP1UP_VERSION="v${SP1UP_VERSION}"
Expand Down
Loading