fix(sdk): proof request signatures #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SP1 Performance Test Results Branch: advaith/proof-request-signatures
|
mattstam
reviewed
Dec 6, 2024
examples/fibonacci/script/Cargo.toml
Outdated
| @@ -7,7 +7,7 @@ publish = false | |||
|
|
|||
| [dependencies] | |||
| hex = "0.4.3" | |||
| sp1-sdk = { workspace = true } | |||
| sp1-sdk = { workspace = true, features = ["network-v2"] } | |||
mattstam
changed the title
mattstam
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Made some RPC changes in the way that signatures are formed. Now it features a specific "format" request parameter of type MessageFormat. We need to reflect these changes in the SP1 code that calls the RPC.
Solution
Simply updated network.rs, and added the "format" request parameter to all requests. Additionally updated signature code in the codebase to ensure consistency with the RPC.
PR Checklist