perf: 1.8x or greater speed improvements in proof recursion #1843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves recursion speed for SP1 by introducing a shape that is closer to the recursion threshold.
See my twitter post for implementation details.
In my test of the aggregation example: (Macbook M3 Pro)
Total time
Old time: ~10m
New time: ~7m
Time for proof compression (core proof -> reduced proof):
Old time: 157s
New time: 85s
It is expected to provide even greater speed improvements for larger programs, although these have not yet been tested. (e.g. ETH block proving)
Before
After