Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preprocessed trace bug #1821

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix: preprocessed trace bug #1821

merged 2 commits into from
Nov 26, 2024

Conversation

ctian1
Copy link
Member

@ctian1 ctian1 commented Nov 26, 2024 •
edited
Loading

Motivation

ProgramMemory chip has a non-deterministic bug

Solution

Sort before generating preprocessed trace from HashMap

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

ratankaliani
ratankaliani approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtguibas jtguibas merged commit 80a97c1 into dev Nov 26, 2024
6 of 14 checks passed
@jtguibas jtguibas deleted the chris/fix-vkey-dev branch November 26, 2024 21:22
ultraspicy pushed a commit to ultraspicy/sp1 that referenced this pull request Dec 4, 2024
@ctian1 @ultraspicy
fix: preprocessed trace bug (succinctlabs#1821)
3ebf63c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratankaliani ratankaliani ratankaliani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctian1 @ratankaliani @jtguibas