Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use a newer reth patch from sp1-patches #32

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

xJonathanLEI
Copy link
Contributor

Currently, RSP uses a bunch of patches for reth, revm, and alloy crates, making it difficult to use latest bug fixes and improvements from upstreams.

This PR uses a new (minimal) patch for reth living under sp1-patches based on a more recent base commit. It also gets to eliminate the need for revm and alloy patches completely. Hopefully the remaining patches for reth will be upstreamed soon so that this fork can be removed too.

In terms of performance, unfortunately, when tested against block 20600000 for 5 runs, this PR increases cycle count from 762,127,033 on current main (a43182d) to 763,527,496, for around 1.4M cycles, or 0.18%. The increase is insignificant but also not negligible.

@xJonathanLEI xJonathanLEI merged commit 41f9d01 into succinctlabs:main Aug 27, 2024
2 checks passed
@xJonathanLEI xJonathanLEI deleted the dev/reth_patch branch August 27, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants