-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: client input caching #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good, just minor style things
bin/host/src/main.rs
Outdated
// and decide on whether to panic later. | ||
// | ||
// On the other hand chain ID is always needed. | ||
let (rpc_url, chain_id) = match (args.rpc_url, args.chain_id) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small code-style thing, but it might be cleaner as a separate function instead of shoved into this already long function
bin/host/src/main.rs
Outdated
} | ||
}; | ||
|
||
let client_input_from_cache = if let Some(cache_dir) = args.cache_dir.as_ref() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, might be nice to have this as a separate function for cleanliness / readability purposes
@puma314 Refactored a bit to cut down the spaghetti. |
2452c09
to
2c7e598
Compare
Rebased due to conflicts. Will merge once CI passes. |
Adds an option to cache client input in the exact same format that would be fed into the client program. When used in combination with
--chain-id
this allows to host to run completely offline.