feat(proposer): remove manual network proof timeout #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proof timeout logic was necessary when we could not assume that the network would correctly set the status of the proof to failed, and the application (op-succinct) had to do this itself to re-request a proof.
This inadvertently causes a backlogged cluster to become even more backlogged.
Ex.
Requested proofs on the cluster (which are capped at
maxConcurrentProofRequests
per proposer) have been generating for >proofTimeout
seconds (e.g. 4 hours). The application "times out" the proofs in it's own state, and re-requests the proofs, putting more load on the network.