make clippy happy

succinctlabs · Jul 24, 2024 · df01883 · df01883
1 parent 964adb7
commit df01883
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/consensus-core/src/consensus_core.rs b/consensus-core/src/consensus_core.rs
@@ -106,7 +106,7 @@ pub fn apply_generic_update(
     store.current_max_active_participants =
         u64::max(store.current_max_active_participants, committee_bits);
 
-    let should_update_optimistic = committee_bits > safety_threshold(&store)
+    let should_update_optimistic = committee_bits > safety_threshold(store)
         && update.attested_header.slot > store.optimistic_header.slot;
 
     if should_update_optimistic {
@@ -144,11 +144,11 @@ pub fn apply_generic_update(
         let store_period = calc_sync_period(store.finalized_header.slot.into());
 
         if store.next_sync_committee.is_none() {
-            store.next_sync_committee = update.next_sync_committee.clone();
+            store.next_sync_committee.clone_from(&update.next_sync_committee);
         } else if update_finalized_period == store_period + 1 {
             info!(target: "helios::consensus", "sync committee updated");
             store.current_sync_committee = store.next_sync_committee.clone().unwrap();
-            store.next_sync_committee = update.next_sync_committee.clone();
+            store.next_sync_committee.clone_from(&update.next_sync_committee);
             store.previous_max_active_participants = store.current_max_active_participants;
             store.current_max_active_participants = 0;
         }

diff --git a/consensus/src/consensus.rs b/consensus/src/consensus.rs
@@ -423,7 +423,7 @@ impl<R: ConsensusRpc> Inner<R> {
     }
 
     pub fn apply_update(&mut self, update: &Update) {
-        let new_checkpoint = apply_update(&mut self.store, &update);
+        let new_checkpoint = apply_update(&mut self.store, update);
         if new_checkpoint.is_some() {
             self.last_checkpoint = new_checkpoint;
         }
@@ -456,11 +456,11 @@ impl<R: ConsensusRpc> Inner<R> {
     }
 
     fn apply_finality_update(&mut self, update: &FinalityUpdate) {
-        let new_checkpoint = apply_finality_update(&mut self.store, &update);
+        let new_checkpoint = apply_finality_update(&mut self.store, update);
         if new_checkpoint.is_some() {
             self.last_checkpoint = new_checkpoint;
         }
-        self.log_finality_update(&update);
+        self.log_finality_update(update);
     }
 
     fn log_finality_update(&self, update: &FinalityUpdate) {
@@ -482,11 +482,11 @@ impl<R: ConsensusRpc> Inner<R> {
     }
 
     fn apply_optimistic_update(&mut self, update: &OptimisticUpdate) {
-        let new_checkpoint = apply_optimistic_update(&mut self.store, &update);
+        let new_checkpoint = apply_optimistic_update(&mut self.store, update);
         if new_checkpoint.is_some() {
             self.last_checkpoint = new_checkpoint;
         }
-        self.log_optimistic_update(&update);
+        self.log_optimistic_update(update);
     }
 
     fn log_optimistic_update(&self, update: &OptimisticUpdate) {

diff --git a/execution/src/proof.rs b/execution/src/proof.rs
@@ -24,7 +24,7 @@ pub fn verify_proof(proof: &[Bytes], root: &[u8], path: &[u8], value: &[u8]) ->
                 }
             } else {
                 let nibble = get_nibble(path, path_offset);
-                expected_hash = node_list[nibble as usize].clone();
+                expected_hash.clone_from(&node_list[nibble as usize]);
 
                 path_offset += 1;
             }
@@ -55,7 +55,7 @@ pub fn verify_proof(proof: &[Bytes], root: &[u8], path: &[u8], value: &[u8]) ->
                     return false;
                 }
                 path_offset += prefix_length;
-                expected_hash = node_list[1].clone();
+                expected_hash.clone_from(&node_list[1]);
             }
         } else {
             return false;