Merge pull request #3 from substancelab/move_to_session

Move request-sending to Session

lib/reconomic/customer.rb

@@ -87,25 +87,6 @@ class Mapper < Shale::Mapper
       map "website", to: :website
       map "zip", to: :zip
     end
-
-    class << self
-      def construct_from(json)
-        from_json(json || "")
-      end
-
-      def retrieve(number:, session:)
-        response = HTTP
-          .headers({
-            :accept => "application/json",
-            "X-AgreementGrantToken" => session.agreement_grant_token,
-            "X-AppSecretToken" => session.app_secret_token
-          })
-          .get(
-            "https://restapi.e-conomic.com/customers/#{number}"
-          )
-        construct_from(response.body.to_s)
-      end
-    end
   end
 
   attr_accessor \
@@ -152,16 +133,8 @@ def construct_from(json)
     end
 
     def retrieve(number:, session:)
-      response = HTTP
-        .headers({
-          :accept => "application/json",
-          "X-AgreementGrantToken" => session.agreement_grant_token,
-          "X-AppSecretToken" => session.app_secret_token
-        })
-        .get(
-          "https://restapi.e-conomic.com/customers/#{number}"
-        )
-      construct_from(response.body.to_s)
+      response_body = session.get("/customers/#{number}")
+      construct_from(response_body)
     end
   end
 end

lib/reconomic/invoice.rb

@@ -144,19 +144,7 @@ def lines
   def save(session:)
     raise "Expected payment terms to not be a string" if payment_terms.is_a?(String)
     body = construct_json_for_save
-
-    response = HTTP
-      .headers({
-        :content_type => "application/json",
-        "X-AgreementGrantToken" => session.agreement_grant_token,
-        "X-AppSecretToken" => session.app_secret_token
-      })
-      .post(
-        "https://restapi.e-conomic.com/invoices/drafts",
-        body: body
-
-      )
-    raise response.body.to_s unless response.status.success?
+    session.post("/invoices/drafts", body)
   end
 
   private

lib/reconomic/session.rb

@@ -8,4 +8,36 @@ def connect_with_token(app_secret_token, agreement_grant_token)
     @agreement_grant_token = agreement_grant_token
     @app_secret_token = app_secret_token
   end
+
+  def get(path)
+    response = authenticated_request.get(url(path))
+    response.body.to_s
+  end
+
+  def hostname
+    URI.parse("https://restapi.e-conomic.com")
+  end
+
+  def post(path, body)
+    response = authenticated_request.post(
+      url(path),
+      body: body
+    )
+    raise response.body.to_s unless response.status.success?
+  end
+
+  private
+
+  def authenticated_request
+    HTTP
+      .headers({
+        :content_type => "application/json",
+        "X-AgreementGrantToken" => agreement_grant_token,
+        "X-AppSecretToken" => app_secret_token
+      })
+  end
+
+  def url(path)
+    hostname + path
+  end
 end

test/reconomic/session_test.rb

@@ -17,4 +17,51 @@
       _(session.agreement_grant_token).must_equal("agreement_grant_token")
     end
   end
+
+  describe "#get" do
+    it "makes a GET request to the API" do
+      body = "{\"customerNumber\":1}"
+      stub_request(:get, "https://restapi.e-conomic.com/customers/1")
+        .to_return(body: body)
+
+      session = Reconomic::Session.new
+      response_body = session.get("/customers/1")
+
+      _(response_body).must_equal({"customerNumber" => 1}.to_json)
+    end
+  end
+
+  describe "#post" do
+    it "makes a POST request to the API" do
+      body = "{\"customerNumber\":1}"
+      stub_request(:post, "https://restapi.e-conomic.com/invoices/drafts")
+        .with(
+          body: body,
+          headers: {
+            "Content-Type" => "application/json"
+          }
+        )
+        .to_return(status: 200)
+
+      session = Reconomic::Session.new
+      session.post("/invoices/drafts", body)
+    end
+
+    it "raises an error if the request fails" do
+      body = "{\"customerNumber\":1}"
+      stub_request(:post, "https://restapi.e-conomic.com/invoices/drafts")
+        .with(
+          body: body,
+          headers: {
+            "Content-Type" => "application/json"
+          }
+        )
+        .to_return(status: 500)
+
+      session = Reconomic::Session.new
+      _ {
+        session.post("/invoices/drafts", body)
+      }.must_raise(RuntimeError)
+    end
+  end
 end