Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Comments part 1 #34
Implemented Comments part 1 #34
Changes from 5 commits
0a4d1a6
4530bb7
70f74cc
a4db8e8
bb4b72f
2c8895d
3ad8d37
ca112bf
4aeee1d
b9c5b5a
ab99246
453bba4
6a9af56
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SvgClassName
isn't needed. We can useclassName
instead to change the styling of the SVG icon. By usingtext-
classes rather thanfill-
. Like we're doing inPostVotes
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you notice that it doesnt work? Those are svg icons not font icons!
text- is good for font icons in our case its svg.
And i would keep it as so, when we want to change the div in the background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works just fine for me.
If we want to change the background color we'll just use a
bg-
class. It won't interfere with the SVG.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm then on firefox this doesnt work. ( or just on my side )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep it does NOT work on firefox and its probably just a sideeffect of chromes svg implementation.
Because of this i would propose to stay what i done for firefox compatibility