Moved comment, changed type and removed optional chaining

sublinks · Jan 8, 2024 · 5a41b03 · 5a41b03
1 parent 1bc91f1
commit 5a41b03
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/components/button/index.tsx b/src/components/button/index.tsx
@@ -3,7 +3,7 @@ import cx from 'classnames';
 
 interface ButtonProps {
   children: React.ReactNode;
-  type: 'button' | 'submit' | 'reset' | undefined;
+  type: 'button' | 'submit' | 'reset';
   id?: string;
   ariaLabel?: string;
   active?: boolean;

diff --git a/src/components/front-page-feed/index.tsx b/src/components/front-page-feed/index.tsx
@@ -16,14 +16,14 @@ interface FeedProps {
 }
 
 const Feed = ({ posts }: FeedProps) => {
-  // @todo: Allow test data when in non-docker dev env
-  // as Sublinks Core doesn't yet handle all post features
   const [postFeed, setPostFeed] = useState<GetPostsResponse>(posts);
 
   // @todo: Set this to the users default feed type
   const [postFeedType, setPostFeedType] = useState<ListingType>();
   const [postFeedSort, setPostFeedSort] = useState<SortType>();
 
+  // @todo: Allow test data when in non-docker dev env
+  // as Sublinks Core doesn't yet handle all post features
   useEffect(() => {
     async function getPosts() {
       setPostFeed(process.env.SUBLINKS_API_BASE_URL ? await sublinksClient().getPosts({
@@ -44,7 +44,7 @@ const Feed = ({ posts }: FeedProps) => {
           currentSort={postFeedSort}
         />
       </div>
-      <PostFeed data={postFeed?.posts || []} />
+      <PostFeed data={postFeed.posts} />
     </div>
   );
 };