-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch for issue #119 #120
base: master
Are you sure you want to change the base?
Patch for issue #119 #120
Conversation
Actually, this is still not quite. While pressing u multiple times now does indeed do multiple undo steps, pressing for example 'i' does not enter insert mode and x doesn't delete characters now, so something is still amiss. |
This is working now with commit 5e3909a :) Please merge. |
Thanks quarnster! This works great. I've been bitten by this more than once. Holding u to undo and going back just a bit too far and then realizing that your redo buffer is empty is very sad. |
Thanks you! Would love to see this merged. |
Here's why this bug makes Vintage mode unusable. If you press "u", and enter visual mode, it is possible to hit another "u" and trigger a case change. This is horrible because it ruins your undo tree! Now you can't redo to recover where you were in the editing process. Does anyone know how to solve this with keymappings in the mean time? |
@quarnster: You may want to amend the diff with support for Redo. #5e3909a fixes undo, but not redo. |
In addition to the
|
Just realized it was very straight forward to get the desired behavior.