Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Bump syntax version to 2 #4097

Closed
wants to merge 1 commit into from
Closed

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 17, 2024

  • My commit messages start with the package name in square brackets, e.g. [XML] .
  • I have included new or enhanced syntax tests to cover the changes.
    this should be covered by the existing tests

To allow embedding it in version 2 syntaxes.

To allow embedding it in version 2 syntaxes.
@jtojnar jtojnar mentioned this pull request Nov 17, 2024
2 tasks
Copy link
Collaborator

@deathaxe deathaxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it doesn't have any benefit beyond possibly breaking some 3rd-party packages.

To allow embedding it in version 2 syntaxes.

Just for the record. This statement is wrong.

v1 syntaxes can be included or embedded into v2 and vice versa without issues.

Version restrictions just exist for syntax inheritance. All syntaxes in an inheritance chain or diamond must be of same syntax version v1 or v2.

@jtojnar jtojnar closed this Nov 17, 2024
@jtojnar
Copy link
Contributor Author

jtojnar commented Nov 17, 2024

Closing in favour of using version: 1 in #4094.

@jtojnar jtojnar deleted the sql-bump branch November 17, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants