-
Notifications
You must be signed in to change notification settings - Fork 118
Add support for @container
queries by updating the CSS language service
#439
Conversation
Thanks @marvinroger Testing this is explained here: https://github.com/styled-components/vscode-styled-components/blob/main/CONTRIBUTING.md#intellisense |
I messed up the link in the description but it's already done styled-components/typescript-styled-plugin#19 This is why this PR is in draft |
Ok great thanks, have you tested these changes locally? |
I did not test locally, but I can confirm that |
https://www.npmjs.com/package/@styled/typescript-styled-plugin has been published |
Thanks, just updated the PR! |
Thanks for doing this! It also looks like @container queries should be supported in the latest version of VSCode (1.85) in .css files based on this Stack Overflow answer but that also doesn't seem to be the case for me either. Not sure what's up. |
Yeah I've tested this branch and I'm still getting the warning too, are we sure this has been fixed in the styled plugin? Sorry I know you've already done work in this repo but you may need to add a test here so we can be sure this has been fixed in the plugin before we try adding it to the extension. I've also updated the main branch so you'll need to rebase if you can too
@macko911 I don't know how you set up before, but if you want to help fix this, I would say follow https://github.com/styled-components/vscode-styled-components/blob/main/CONTRIBUTING.md#intellisense Then set some breakpoints in the styled plugin to see why its still warning about the unknown property at rule |
This PR updates the CSS language service in order to support
@container
queries.C.f. microsoft/vscode-css-languageservice#365 and microsoft/vscode-css-languageservice#371
The PR is ready to be published to npm 😉