Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Disable XML RPC endpoint by default #21

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

titouanmathis
Copy link
Contributor

@titouanmathis titouanmathis commented Oct 19, 2023

XML-RPC is an old feature of WordPress, mainly targeted by bots. It can be disabled by default.

See https://kinsta.com/blog/xmlrpc-php/.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7f2342f) 61.34% compared to head (34a756b) 64.37%.

❗ Current head 34a756b differs from pull request most recent head 3146b9c. Consider uploading reports for the commit 3146b9c to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #21      +/-   ##
=============================================
+ Coverage      61.34%   64.37%   +3.03%     
- Complexity       150      152       +2     
=============================================
  Files              7        7              
  Lines            388      393       +5     
=============================================
+ Hits             238      253      +15     
+ Misses           150      140      -10     
Flag Coverage Δ
unittests 64.37% <100.00%> (+3.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Managers/CleanupManager.php 37.25% <100.00%> (+28.55%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titouanmathis titouanmathis force-pushed the feature/xml-rpc branch 4 times, most recently from 62e16c7 to 34a756b Compare October 19, 2023 09:31
@titouanmathis titouanmathis merged commit 46422ad into develop Oct 19, 2023
12 checks passed
@titouanmathis titouanmathis deleted the feature/xml-rpc branch October 19, 2023 11:58
@titouanmathis titouanmathis mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant