Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind v3 and v4 as a starter kit module #405

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andjsch
Copy link
Contributor

@andjsch andjsch commented Nov 27, 2024

This PR adds Tailwind as a starter kit module, asking you which version you want to install.

Known bugs:

  • Despite setting skip_option: false there is still an empty choice shown and the default (v3) not selected. Fixed by new statamic/statamic version.

@jesseleite
Copy link

jesseleite commented Nov 27, 2024

Re: skip_option: false not working, seems to work here 🤔

CleanShot 2024-11-27 at 13 22 41

What version of statamic/cms is installed in your app when running php please starter-kit:install?

This skip_option: false handling was only tagged yesterday in 5.40.0. (See: statamic/cms#11045)

@jesseleite
Copy link

It might be a good idea to add "statamic/cms": "^5.40" to peak's composer.json to ensure it can only be installed in latest versions, and you can bump that as you rely on new cutting edge starter kit installer features.

@andjsch
Copy link
Contributor Author

andjsch commented Nov 28, 2024

It might be a good idea to add "statamic/cms": "^5.40" to peak's composer.json to ensure it can only be installed in latest versions, and you can bump that as you rely on new cutting edge starter kit installer features.

Yep, that was it. It got fixed with the new version of statamic/statamic. Thanks for taking a look!

@robdekort
Copy link
Contributor

Having talked about this with Andy, we're going to await this PR statamic/cms#11119 to solve the issue of shipping two versions of Tailwind.

Thanks both! ❤️

@robdekort robdekort marked this pull request as draft November 28, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants