Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: release package #67

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Chore: release package #67

merged 1 commit into from
Feb 6, 2023

Conversation

niek-mereu
Copy link
Collaborator

@niek-mereu niek-mereu commented Feb 3, 2023 •
edited
Loading

📝 Changelog

  • add MIT license
  • add github action to package to pypi
  • send package information from package.json to setup.py

🔗 Links

✅ Checklist

  • Lint and tests pass locally with my changes

@niek-mereu niek-mereu marked this pull request as draft February 3, 2023 10:09
@niek-mereu niek-mereu force-pushed the chore/release-package branch 3 times, most recently from 02901a4 to e6663b2 Compare February 3, 2023 15:01
@niek-mereu niek-mereu marked this pull request as ready for review February 3, 2023 15:03
jardabezdek
jardabezdek suggested changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@jardabezdek jardabezdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, @niekstrv! 💪 I have the only comment, and it is about versioning. I think it should be described. 👍

README.md Outdated Show resolved Hide resolved
jardabezdek
jardabezdek approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@jardabezdek jardabezdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the README.md file, @niekstrv! I find versioning process a little bit complicated, so I would suggest automating it. However, I am giving an approve for now, since I don't think it is a priority. 👍

README.md Outdated
Add the tag to the current branch like this:

Follow the steps below to create a new release:
1. Update `package.yml` with the new version number.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no package.yml file in the repository. Did you mean package.json?

@niek-mereu niek-mereu changed the title Chore/release package Chore: release package Feb 6, 2023
@niek-mereu niek-mereu merged commit 6814ff9 into master Feb 6, 2023
@niek-mereu niek-mereu deleted the chore/release-package branch February 6, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jardabezdek jardabezdek jardabezdek approved these changes

@joeythedataguy joeythedataguy joeythedataguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niek-mereu @joeythedataguy @jardabezdek