Skip to content

Commit

Permalink
chore: upgrade deps & ESLint, drop older Node.js support
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Minimum supported Node.js version is now v18 and v20.
  • Loading branch information
robertrossmann committed Jul 11, 2023
1 parent 4e3b67b commit 45fb9d8
Show file tree
Hide file tree
Showing 10 changed files with 10,976 additions and 15,671 deletions.
33 changes: 16 additions & 17 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,12 @@ const os = require('os')

const lbstyle = os.platform() === 'win32' ? 'windows' : 'unix'

/** @type {import("eslint").Linter.Config} */
module.exports = {
reportUnusedDisableDirectives: true,

parserOptions: {
ecmaVersion: 2022,
},

extends: [
'@strv/node/v16',
'@strv/node/v20',
'@strv/node/optional',
'@strv/node/style',
],
Expand All @@ -37,24 +34,30 @@ module.exports = {

overrides: [{
files: [
'src/**/*.ts',
'test/**/*.ts',
'test/**/*.test.ts',
'**/*.ts',
],

extends: [
'@strv/node/v16',
'@strv/node/v20',
'@strv/node/optional',
'@strv/eslint-config-typescript',
'@strv/eslint-config-typescript/style',
'@strv/mocha',
'@strv/typescript',
'@strv/typescript/style',
],

parserOptions: {
ecmaVersion: 2022,
project: 'tsconfig.json',
},

rules: {
'linebreak-style': ['error', lbstyle],
},
}, {
files: [
'**/*.test.ts',
],
extends: [
'@strv/mocha',
],
env: {
// Disable Mocha globals which are enabled in @strv/mocha. We will import the necessary
// functions directly from 'mocha' package in this project.
Expand All @@ -63,9 +66,5 @@ module.exports = {
// available in test files - they are either fully available or not available at all.
mocha: false,
},

rules: {
'linebreak-style': ['error', lbstyle],
},
}],
}
8 changes: 4 additions & 4 deletions .github/workflows/commitlint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,18 @@ on:

jobs:
commitlint:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
timeout-minutes: 5
env:
CI: 'true'

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 50
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
cache: npm

- run: make install
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,18 @@ on:

jobs:
release:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
timeout-minutes: 10
env:
CI: 'true'

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
cache: npm

- run: make install
Expand Down
14 changes: 6 additions & 8 deletions .github/workflows/integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,19 @@ jobs:
matrix:
os:
- ubuntu-20.04
- macos-11
- macos-13
- windows-2022
node:
- 12
- 14
- 16
- 18
- 20

runs-on: ${{ matrix.os }}
timeout-minutes: 10
env:
CI: 'true'

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: actions/setup-node@v3
Expand All @@ -42,18 +40,18 @@ jobs:
run: make test

coverage:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
timeout-minutes: 10
env:
CI: 'true'

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20

- run: make install
- run: make compile
Expand Down
Loading

0 comments on commit 45fb9d8

Please sign in to comment.