Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify remote to stop publishing when last local subscriber is closed. #860

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

fancycode
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Nov 7, 2024

Pull Request Test Coverage Report for Build 11776055961

Details

  • 89 of 150 (59.33%) changed or added relevant lines in 7 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+4.1%) to 63.883%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mcu_proxy.go 0 1 0.0%
mcu_janus_remote_publisher.go 1 3 33.33%
mcu_janus_publisher.go 0 5 0.0%
janus_client.go 1 7 14.29%
proxy/proxy_session.go 50 58 86.21%
mcu_janus.go 10 20 50.0%
proxy/proxy_server.go 27 56 48.21%
Files with Coverage Reduction New Missed Lines %
mcu_janus_publisher.go 1 12.1%
grpc_client.go 2 79.31%
mcu_proxy.go 2 60.33%
Totals Coverage Status
Change from base Build 11775730446: 4.1%
Covered Lines: 11865
Relevant Lines: 18573

💛 - Coveralls

@fancycode fancycode force-pushed the unpublish-remote branch 2 times, most recently from 6e5351c to 6f36e5e Compare November 11, 2024 09:38
@fancycode fancycode marked this pull request as ready for review November 11, 2024 10:47
@fancycode fancycode merged commit 8a53bab into master Nov 11, 2024
19 checks passed
@fancycode fancycode deleted the unpublish-remote branch November 11, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants