Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode session ids using protobufs. #850

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Encode session ids using protobufs. #850

merged 1 commit into from
Oct 28, 2024

Conversation

fancycode
Copy link
Member

This will reduce their size and improve encoding / decoding performance.

Also fixes GO-2024-3106 (Stack exhaustion in Decoder.Decode in encoding/gob).

@fancycode fancycode force-pushed the sessionid-protobuf branch 2 times, most recently from f8c9c42 to 709b5ef Compare October 28, 2024 13:31
@coveralls
Copy link

coveralls commented Oct 28, 2024

Pull Request Test Coverage Report for Build 11555347272

Details

  • 80 of 95 (84.21%) changed or added relevant lines in 4 files are covered.
  • 10 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 59.22%

Changes Missing Coverage Covered Lines Changed/Added Lines %
proxy/proxy_server.go 3 4 75.0%
hub.go 28 30 93.33%
client/main.go 0 6 0.0%
sessionid_codec.go 49 55 89.09%
Files with Coverage Reduction New Missed Lines %
client/main.go 1 0.0%
mcu_proxy.go 2 60.78%
grpc_client.go 3 78.68%
dns_monitor.go 4 94.12%
Totals Coverage Status
Change from base Build 11552635147: 0.1%
Covered Lines: 10768
Relevant Lines: 18183

💛 - Coveralls

This will reduce their size and improve encoding / decoding performance.

Also fixes GO-2024-3106 (Stack exhaustion in Decoder.Decode in encoding/gob).
@fancycode fancycode merged commit a4f0b10 into master Oct 28, 2024
25 of 27 checks passed
@fancycode fancycode deleted the sessionid-protobuf branch October 28, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants