Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move common flags code to own struct. #591

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Move common flags code to own struct. #591

merged 1 commit into from
Oct 30, 2023

Conversation

fancycode
Copy link
Member

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6690415732

  • 41 of 45 (91.11%) changed or added relevant lines in 3 files are covered.
  • 13 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.05%) to 54.526%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flags.go 32 34 94.12%
virtualsession.go 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
grpc_client.go 1 78.95%
hub.go 2 74.47%
virtualsession.go 4 73.12%
clientsession.go 6 63.85%
Totals Coverage Status
Change from base Build 6690303254: -0.05%
Covered Lines: 7295
Relevant Lines: 13379
💛 - Coveralls

@fancycode fancycode merged commit 00c2e4e into master Oct 30, 2023
14 checks passed
@fancycode fancycode deleted the common-flags branch October 30, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fancycode @coveralls