-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for paymentMethodOrder #1662
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
062f627
feat: add support for paymentMethodOrder
charliecruzan-stripe cbba49c
remove flipper
charliecruzan-stripe 7177cd5
changelog, upgrade checkout action
charliecruzan-stripe ce33ace
use node 20
charliecruzan-stripe a6b4251
use 18 instaed
charliecruzan-stripe 1f3fbbe
use node 16
charliecruzan-stripe c8c363d
update java version on GHA
charliecruzan-stripe ce23036
use macos-13
charliecruzan-stripe dd2c2a4
fix ios CI builds
charliecruzan-stripe ae3cf0b
upgrade android
charliecruzan-stripe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,10 +9,10 @@ on: | |
jobs: | ||
test-android: | ||
name: e2e-android-test | ||
runs-on: macos-latest | ||
runs-on: macos-13 | ||
steps: | ||
- name: checkout | ||
uses: actions/checkout@v2 | ||
uses: actions/checkout@v4 | ||
|
||
- name: Get yarn cache directory path | ||
id: yarn-cache-dir-path | ||
|
@@ -29,7 +29,7 @@ jobs: | |
- name: Setup Node.js environment | ||
uses: actions/[email protected] | ||
with: | ||
node-version: 14.15.0 | ||
node-version: 16 | ||
|
||
- name: Install React Native CLI | ||
run: npm install react-native-cli | ||
|
@@ -41,7 +41,7 @@ jobs: | |
uses: actions/setup-java@v3 | ||
with: | ||
distribution: 'zulu' | ||
java-version: '11' | ||
java-version: '17' | ||
|
||
- name: Gradle cache | ||
uses: actions/cache@v2 | ||
|
@@ -72,10 +72,10 @@ jobs: | |
|
||
test-ios: | ||
name: e2e-ios-test | ||
runs-on: macos-latest | ||
runs-on: macos-13 | ||
steps: | ||
- name: checkout | ||
uses: actions/checkout@v2 | ||
uses: actions/checkout@v4 | ||
|
||
- name: Get yarn cache directory path | ||
id: yarn-cache-dir-path | ||
|
@@ -99,7 +99,7 @@ jobs: | |
- name: Setup Node.js environment | ||
uses: actions/[email protected] | ||
with: | ||
node-version: 14.15.0 | ||
node-version: 16 | ||
|
||
- name: Install React Native CLI | ||
run: npm install react-native-cli | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ jobs: | |
runs-on: ubuntu-latest | ||
steps: | ||
- name: checkout | ||
uses: actions/checkout@v2 | ||
uses: actions/checkout@v4 | ||
|
||
- name: Get yarn cache directory path | ||
id: yarn-cache-dir-path | ||
|
@@ -27,7 +27,7 @@ jobs: | |
- name: Setup Node.js environment | ||
uses: actions/[email protected] | ||
with: | ||
node-version: 14.15.0 | ||
node-version: 16 | ||
|
||
- name: Install Dependencies | ||
run: | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,10 +9,10 @@ on: | |
jobs: | ||
test-ios: | ||
name: unit-test-ios | ||
runs-on: macos-12 | ||
runs-on: macos-13 | ||
steps: | ||
- name: checkout | ||
uses: actions/checkout@v2 | ||
uses: actions/checkout@v4 | ||
|
||
- name: Get yarn cache directory path | ||
id: yarn-cache-dir-path | ||
|
@@ -36,7 +36,7 @@ jobs: | |
- name: Setup Node.js environment | ||
uses: actions/[email protected] | ||
with: | ||
node-version: 14.15.0 | ||
node-version: 16 | ||
|
||
- name: Install React Native CLI | ||
run: npm install react-native-cli | ||
|
@@ -49,10 +49,10 @@ jobs: | |
|
||
test-android: | ||
name: unit-test-android | ||
runs-on: macos-latest | ||
runs-on: macos-13 | ||
steps: | ||
- name: checkout | ||
uses: actions/checkout@v2 | ||
uses: actions/checkout@v4 | ||
|
||
- name: Get yarn cache directory path | ||
id: yarn-cache-dir-path | ||
|
@@ -69,7 +69,7 @@ jobs: | |
- name: Setup Node.js environment | ||
uses: actions/[email protected] | ||
with: | ||
node-version: 14.15.0 | ||
node-version: 16 | ||
|
||
- name: Install React Native CLI | ||
run: npm install react-native-cli | ||
|
@@ -81,7 +81,7 @@ jobs: | |
uses: actions/setup-java@v3 | ||
with: | ||
distribution: 'zulu' | ||
java-version: '11' | ||
java-version: '17' | ||
|
||
- name: Gradle cache | ||
uses: actions/cache@v2 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
StripeSdk_kotlinVersion=1.8.0 | ||
# Keep StripeSdk_stripeVersion in sync with https://github.com/stripe/stripe-identity-react-native/blob/main/android/gradle.properties | ||
StripeSdk_stripeVersion=20.41.+ | ||
StripeSdk_stripeVersion=20.44.+ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this always defaulting to true? if I inject
allowsRemovalOfLastSavedPaymentMethod
beingfalse
this code would default totrue
@charliecruzan-stripeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, the elvis operator tests whether the left hand side is non-null: https://kotlinlang.org/docs/null-safety.html#elvis-operator
here's some sample code to prove this will evaluate to
false
ifallowsRemovalOfLastSavedPaymentMethod
is false