Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for starting Kafka Connect #117

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mimaison
Copy link
Contributor

Basic support for starting Kafka Connect.

@see-quick
Copy link
Member

You would need to create more UTs to cover both classes to reach the current threshold. I can show you where to look at it and how to analyze it if you want :).

[ERROR] Failed to execute goal org.pitest:pitest-maven:1.17.2:mutationCoverage (default-cli) on project strimzi-test-container: Mutation score of 77 is below threshold of 91 -> [Help 1]

@mimaison
Copy link
Contributor Author

Any pointers would be helpful. As far as I can tell there are tests calling all the methods.

@see-quick see-quick added this to the 0.110.0 milestone Dec 20, 2024
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good! Thanks for implementing this 👍 just a few nits...

mimaison and others added 11 commits January 7, 2025 10:41
…r.java

Co-authored-by: Maros Orsak <[email protected]>
Signed-off-by: Mickael Maison <[email protected]>
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @mimaison ! 👍

@see-quick see-quick added the enhancement New feature or request label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants