-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for starting Kafka Connect #117
base: main
Are you sure you want to change the base?
Conversation
5e59e88
to
3ba3936
Compare
You would need to create more UTs to cover both classes to reach the current threshold. I can show you where to look at it and how to analyze it if you want :). [ERROR] Failed to execute goal org.pitest:pitest-maven:1.17.2:mutationCoverage (default-cli) on project strimzi-test-container: Mutation score of 77 is below threshold of 91 -> [Help 1] |
Any pointers would be helpful. As far as I can tell there are tests calling all the methods. |
3ba3936
to
ee423be
Compare
Signed-off-by: Mickael Maison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good! Thanks for implementing this 👍 just a few nits...
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectContainer.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…r.java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @mimaison ! 👍
Basic support for starting Kafka Connect.