Fix html escaping of source line marks #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislaw
reviewed
Jul 26, 2024
haxtibal
force-pushed
the
tdmg/fix_sdoc_fileref
branch
from
b5ba85e to
bf65922
Compare
haxtibal
commented
Jul 26, 2024
haxtibal
force-pushed
the
tdmg/fix_sdoc_fileref
branch
2 times, most recently
from
83afcc7 to
dcc30f4
Compare
SourceFileViewHTMLGenerator escaping code had multiple issues: - When marking each line from range_start_pragma_processor as safe, we wrapped not only strings but also whole tuples in Markup(). - For tuple elements we didn't differentiate whether they from pygments (already escaped) or from source file (not yet escaped). Only the later must be explicitly escaped. Some changes are there to make mypy happy. Relates to strictdoc-project#1921.
haxtibal
force-pushed
the
tdmg/fix_sdoc_fileref
branch
from
dcc30f4 to
134b9a1
Compare
|
This failed MacOS e2e test looks unrelated. I'm not on MacOS, can't reproduce locally. Do you know what's up? |
It is one of the tests that are known to be flaky. They fail sometimes. Most of the time they are timeout errors of some kind but not always. I track the known ones here, and this one didn't fail before: #1912. I just restarted the macOS tests and they have all passed. |
8 tasks
stanislaw
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceFileViewHTMLGeneratorescaping code had multiple issues:range_start_pragma_processoras safe, we wrapped not only strings but also whole tuples inMarkup().Relates to #1921.