[Bug] Inactive articles are shown in the "BUY ARTICLE" menu

[shokinn]

Hi There,
I found a small bug in "BUY ARTICLE" menu within the user view.
Articles will still be displayed, when they are moved to "INACTIVE ARTICLES", but only when the "INACTIVE ARTICLES" list was visited before.

Steps to reproduce:

1. Open your Strichliste instance
2. Force reload (incl. clear cache) your Browser (e.g. for Firefox on macOS command + shift + R)
3. Open a user
4. Open the "BUY ARTICLE" tab
5. You should now see only the "ACTIVE ARTICLES"
6. Go to "Article List"
7. Open the "INACTIVE ARTICLES" tab
8. Go back to Strichlistes main page
9. Open a user
10. Open the "BUY ARTICLE" tab
11. Now all articles from "ACTIVE ARTICLES" and "INACTIVE ARTICLES" are displayed.

Workaround:
Reload the page.
Which does not work well when you use Strichliste as Progressive Web App on an iPad with Guided access enabled (App is opened and closing the app is prevented).

[schinken]

Good point. Maybe we can summon @sanderdrummer ;)?

I'm a total frontend noob :D

[sanderdrummer]

I could not reproduce it.
I checked the flow, and only active items are on the list 🤔.
We explicitly filter for active items in the selector.

strichliste-web-frontend/src/store/reducers/article.ts

Line 245 in 05c3611

.filter(article => article.isActive)

The only way to get the behaviour is to remove that filter.

[shokinn]

Mhh interesting.
I didn't modified anything.

I just updated to strichliste from 1.7.1 to 1.8.2 and php from 7.4-fpm to 8.1-fpm.
I've still the same issue with a freshly pulled release from here https://github.com/strichliste/strichliste/releases/tag/v1.8.2.

If you would like to try my deployment:
https://github.com/shokinn/strichliste-docker

There is a docker-compose ready to run.
It will take a while after the database container is up until the other containers start, since they wait for a health db container state.