fix(user): sort user by name

strichliste · Jan 9, 2019 · 61c1742 · 61c1742
1 parent f07dd0d
commit 61c1742
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/store/reducers/__tests__/user.spec.ts b/src/store/reducers/__tests__/user.spec.ts
@@ -184,12 +184,12 @@ describe('action creators', () => {
 
 describe('selectors', () => {
   describe('getUserArray', () => {
-    it('returns the current user map as an arry', () => {
+    it('returns the current user map as an array', () => {
       expect(
         getUserArray({
-          user: { 1: { id: 1 }, 2: { id: 2 } },
+          user: { 1: { id: 1, name: 'a' }, 2: { id: 2, name: 'b' } },
         } as any)
-      ).toEqual([{ id: 1 }, { id: 2 }]);
+      ).toEqual([{ id: 1, name: 'a' }, { id: 2, name: 'b' }]);
     });
   });
   describe('getUser', () => {

diff --git a/src/store/reducers/user.ts b/src/store/reducers/user.ts
@@ -206,7 +206,9 @@ export function getUserState(state: AppState): UsersState {
 }
 
 export function getUserArray(state: AppState): User[] {
-  return Object.values(getUserState(state));
+  return Object.values(getUserState(state)).sort((a: User, b: User) =>
+    a.name.localeCompare(b.name)
+  );
 }
 
 export function getUser(state: AppState, userId: number): User | undefined {