Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support permission init for control plane management volume #104

Merged
merged 33 commits into from
Jan 8, 2025
Merged

feat: Support permission init for control plane management volume #104

merged 33 commits into from
Jan 8, 2025

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Dec 23, 2024

No description provided.

@tuteng tuteng requested a review from a team as a code owner December 23, 2024 01:27
@tuteng tuteng changed the title Support permission init for control plane management volume feat: Support permission init for control plane management volume Dec 23, 2024
ciiiii
ciiiii reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@ciiiii ciiiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming this module volume-access would be better to maintain consistency with format of vendor-access.

modules/aws/sn-volume-access/variables.tf Outdated Show resolved Hide resolved
modules/aws/sn-volume-access/files/sn_volume_s3_bucket.json.tpl Outdated Show resolved Hide resolved
modules/aws/sn-volume-access/files/sn_volume_s3_bucket.json.tpl Outdated Show resolved Hide resolved
tuteng
tuteng commented Dec 30, 2024
View reviewed changes
examples/volume-access/main.tf
}

module "sn_managed_cloud" {
source = "../../modules/aws/volume-access"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change it after this pr approve and merged

maxsxu
maxsxu reviewed Jan 7, 2025
View reviewed changes
modules/aws/volume-access/main.tf Outdated Show resolved Hide resolved
modules/aws/volume-access/main.tf Outdated Show resolved Hide resolved
modules/aws/volume-access/main.tf Outdated Show resolved Hide resolved
modules/aws/volume-access/main.tf Outdated Show resolved Hide resolved
modules/aws/volume-access/main.tf Outdated Show resolved Hide resolved
modules/aws/volume-access/main.tf Outdated Show resolved Hide resolved
maxsxu
maxsxu approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuteng tuteng merged commit 54cfb6f into main Jan 8, 2025
4 checks passed
@tuteng tuteng deleted the feature/support-init-sn-volume-access branch January 8, 2025 13:15
@streamnativebot streamnativebot mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciiiii ciiiii ciiiii left review comments

@maxsxu maxsxu maxsxu approved these changes

Assignees

@tuteng tuteng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuteng @maxsxu @ciiiii