call equals on formatted strings since they will never be null (#1211)

streamnative · Jan 17, 2024 · 62e93cb · 62e93cb
1 parent 7ac60ae
commit 62e93cb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/.../src/main/java/io/streamnative/pulsar/handlers/mqtt/proxy/PulsarServiceLookupHandler.java b/.../src/main/java/io/streamnative/pulsar/handlers/mqtt/proxy/PulsarServiceLookupHandler.java
@@ -158,8 +158,8 @@ private boolean isLookupMQTTBroker(Pair<InetSocketAddress, InetSocketAddress> pa
         String plain = String.format("pulsar://%s:%s", pair.getLeft().getHostName(), pair.getLeft().getPort());
         String ssl = String.format("pulsar+ssl://%s:%s", pair.getLeft().getHostName(), pair.getLeft().getPort());
         return localBrokerData.getProtocol(protocolHandlerName).isPresent()
-                && (localBrokerData.getPulsarServiceUrl().equals(plain)
-                    || localBrokerData.getPulsarServiceUrlTls().equals(ssl));
+                && (plain.equals(localBrokerData.getPulsarServiceUrl())
+                    || ssl.equals(localBrokerData.getPulsarServiceUrlTls()));
     }
 
     @Override