Fix/abi fun int128 encoding #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoueh
reviewed
Dec 11, 2023
abigen/src/lib.rs
Outdated
| @@ -245,11 +245,12 @@ fn to_token(name: &proc_macro2::TokenStream, kind: &ParamType) -> proc_macro2::T | |||
| } | |||
| ParamType::Bytes => quote! { ethabi::Token::Bytes(#name.clone()) }, | |||
| ParamType::FixedBytes(_) => quote! { ethabi::Token::FixedBytes(#name.as_ref().to_vec()) }, | |||
| ParamType::Int(_) => { | |||
| ParamType::Int(size) => { | |||
| let full_signed_bytes_init = if size == 128 { 0x00 } else { 0xff }; | |||
There was a problem hiding this comment.
The 128 check feels weird, why a i128 would be different than a i64. I'm surprised here.
If you use 0x00 directly.
colindickson
force-pushed
the
fix/abi-fun-int128-encoding
branch
from
1f9691e to
e41fe60
Compare
colindickson
force-pushed
the
fix/abi-fun-int128-encoding
branch
from
e41fe60 to
4f59667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.