Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link hover color #1765

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix: link hover color #1765

merged 1 commit into from
Jul 26, 2024

Conversation

madhurisandbhor
Copy link
Contributor

What does it do?

Apply link hover color to its label and not to children

Why is it needed?

In CMS, where we are using Link component as a wrapper with children inside it, its causing hover style to apply to all its span elements unnecessarily.

@madhurisandbhor madhurisandbhor added pr: fix This PR is fixing a bug source: design-system relates to design-system package labels Jul 26, 2024
@madhurisandbhor madhurisandbhor self-assigned this Jul 26, 2024
Copy link

changeset-bot bot commented Jul 26, 2024

🦋 Changeset detected

Latest commit: a58db4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Patch
@strapi/icons Patch
@strapi/ui-primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 2:19pm

@madhurisandbhor madhurisandbhor marked this pull request as ready for review July 26, 2024 14:35
@madhurisandbhor madhurisandbhor changed the title fix: link hover color apply to its label and not to children fix: link hover color Jul 26, 2024
@madhurisandbhor madhurisandbhor merged commit ae052a2 into main Jul 26, 2024
12 checks passed
@madhurisandbhor madhurisandbhor deleted the fix/link-hover branch July 26, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants