-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit selectedTabIndex and selectTabIndex in TabGroup #1394
Conversation
🦋 Changeset detectedLatest commit: ae4ccf0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: 0 B Total Size: 552 kB ℹ️ View Unchanged
|
@christiancp100 this needs a changeset before we can proceed. But the code change looks fine 👍🏼 |
030a5ee
to
ae4ccf0
Compare
What does it do?
It omits selectedTabIndex and selectTabIndex in TabGroup because they are not required as props since they are being passed to the context inside the TabGroup component.
Why is it needed?
To avoid TS errors.
How to test it?
Check that the TabGroup component doesn't fail when you don't pass the selectTabIndex and selectedTabIndex properties to it.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request