-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Combobox rendered text when value prop changes #1381
Conversation
🦋 Changeset detectedLatest commit: c80c271 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +201 B (0%) Total Size: 552 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can add a test case? I worry that this could easily regress 😬
Do you know how to add a changeset? 🤩 |
0c8bcd1
to
c80c271
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it do?
Updates the Combobox rendered value if the corresponding prop changes "externally" (without clicking an option)
Why is it needed?
Because if the prop changes, the "internal" value is actually updated but the rendered text not
How to test it?
I tested this manually, let me know if I should update UT
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request