Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove engines for node 20, various cleanup #22

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Remove engines for node 20, various cleanup #22

merged 1 commit into from
Jan 31, 2024

Conversation

derrickmehaffy
Copy link
Collaborator

@derrickmehaffy derrickmehaffy commented Jan 31, 2024 •
edited
Loading

Changes:

  • Removed the engines config from the package.json to prevent future node verisons from breaking the plugin (should just support everything Strapi supports)
  • Removed broken community eslint, plus I really don't use it
  • Ran tests against every minor strapi version since the last time it was updated
  • Moved the plugin loading from bootstrap to register to fix issues with other plugins and load order
  • Various other cleanup

@derrickmehaffy derrickmehaffy added bug Something isn't working enhancement New feature or request labels Jan 31, 2024
@derrickmehaffy derrickmehaffy self-assigned this Jan 31, 2024
@derrickmehaffy derrickmehaffy merged commit 0387b03 into main Jan 31, 2024
3 checks passed
@derrickmehaffy derrickmehaffy deleted the upgrade/node20 branch January 31, 2024 02:48
@derrickmehaffy derrickmehaffy mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derrickmehaffy derrickmehaffy

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@derrickmehaffy