-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract email templates into individual classes #3234
Open
dparker1005
wants to merge
57
commits into
dev
Choose a base branch
from
enhancement/email-template-abstraction
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create email template class
* Fix for sitename variable
* Pass level id to cancel function from edit member page
*Add missing variables for backwards compat
* Add Change Membership Classes ( admin and member )
…celed-auto-renewals * Add canceled autorenewal template / classes for member and admin
…and its references
…sent in the abstract Email Template Class.
* Compare param user with order user and use the one from the order if they don't match.
…t/add-billing-failure-class
…ling-failure-class Add payment failure classes
…t/add-billing-info-class
…ling-info-class * Add billing info updated and billing info updated admin classes
…t/add-checkout-check
…ckout-check * Add checkout templates
…t/add-credit-card-expiring-class
…dit-card-expiring-class * Add credit card expiring email class
…t/membership-expired
…t/membership-expiring
…hip-expired *add expired membership email class
…t/membership-expiring
…hip-expiring [ENHANCEMENT] * Add Membership expiring email class
…t/payment-template-classes
…-template-classes * Add Payment Email Classes
…t/add-refund-email-class
…und-email-class * Add refund email classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Creating an abstract class for email templates will allow us to avoid duplicate code that is common across every email template. Separating each template into a separate class will then make it easier to modify existing emails and add additional email templates down the road.
Other information:
Changelog entry