Reset query params to the initial params when un-mounting. #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered the same issue as #1 and ended up fixing it locally in our own decorator–no longer using this addon–but I might as well push it upstream to this addon. Further basis in that issue and this comment. Should fix #1.
When unmounting our Story, this takes the
initialSearch
(the initiallocation.search
) and setlocation.search
to the original value.initialSearch.current
is from the very first render and never updated.Quick video to visualize the Storybook file changes:
https://www.loom.com/share/bc19e586965f45a7b9b17b865b7e79ed