-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Adds troubleshooting for test flag #36
Conversation
test: { | ||
disabledAddons: [ | ||
'@storybook/addon-docs', | ||
'@storybook/addon-essentials/docs', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed in the snippet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, based on the comment from Shilman. I tested it out and was able to see the issue and the fix.
README.md
Outdated
'@storybook/addon-links', | ||
'@storybook/addon-essentials', | ||
'@storybook/addon-interactions', | ||
'@storybook/addon-coverage', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to add the whole list, or the addons field at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can tweak the addons—no problem at all there. I just copied them over from an existing reproduction.
With this pull request, the README file was updated to factor in a troubleshooting section to address and close #31 until a proper fix is provided.
What was done:
@yannbf or @kasperpeulen, when you have a moment, can you take a look at this and follow up with me on it? Thanks in advance