Handle 404s on images and internal links

storj · Sep 29, 2023 · 2de602f · 2de602f
1 parent 0c1736d
commit 2de602f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/markdoc/convertDocId.js b/src/markdoc/convertDocId.js
@@ -21,19 +21,18 @@ function getFrontmatter(filePath) {
 }
 
 export function convertDocId(href) {
-  if (href?.includes('docs.storj.io')) {
+  const siteHost = new URL(process.env.SITE_URL).host
+  if (href?.includes(siteHost)) {
     const url = new URL(href)
     let dir = path.resolve('./app')
     const filePath = path.join(dir, url.pathname, 'page.md')
-    if (
-      process.env.NODE_ENV !== 'production' ||
-      (url.host === new URL(process.env.SITE_URL).host && existsSync(filePath))
-    ) {
+    if (existsSync(filePath)) {
       let { docId } = getFrontmatter(filePath)
       throw new Error(
         `Internal links should use the docId. replace ${href} with docId:${docId}`
       )
     }
+    throw new Error(`Could not find document for ${href}`)
   }
 
   if (!href?.startsWith('docId')) {

diff --git a/src/markdoc/nodes.js b/src/markdoc/nodes.js
@@ -117,7 +117,11 @@ const nodes = {
       let result = imageSizeCache[hash]
       if (!result) {
         console.warn(`image size not cached, probing... ${attributes.src}`)
-        result = await probe(attributes.src)
+        try {
+          result = await probe(attributes.src)
+        } catch (err) {
+          throw new Error(`${err}\nOccurred on ${attributes.src}`)
+        }
       }
 
       return new Tag(