Fix url parsing that caused v1 test to fail

storageos · Mar 11, 2020 · b73caed · b73caed
1 parent 19f3d91
commit b73caed
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/netutil/parsers.go b/netutil/parsers.go
@@ -55,6 +55,12 @@ func AddressesFromNodes(nodes []string) ([]string, error) {
 			return nil, newInvalidNodeError(errInvalidHostName)
 		}
 
+		// Given input like "http://localhost:8080:8383", url.Parse() will
+		// return host as "localhost:8000", which isn't a vaild DNS name.
+		if strings.Contains(host, ":") {
+			return nil, newInvalidNodeError(errInvalidHostName)
+		}
+
 		port := url.Port()
 		if port == "" {
 			port = DefaultDialPort