This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
Remove dead code after dropping support for k8s 1.16 and earlier #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croomes
force-pushed
the
remove-old-images
branch
2 times, most recently
from
b922906 to
50b32c2
Compare
* Remove some other v1.14 specific logic * Remove unused func
croomes
force-pushed
the
remove-old-images
branch
from
9042f6f to
b505ddc
Compare
croomes
added
the
do-not-merge/wip
mhmxs
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some complexity that was required for earlier versions of Kubernetes to select appropriate images. From k8s 1.15 onwards, image selection is static, apart from adding the csi-resizer from k8s 1.16 onwards.
This helps avoid confusion about which images should be pre-loaded into private registries.
Also removes the NFS controller that was used in StorageOS v1.
There are no changes to the StorageOSCluster CR so upgrades will work as before. Attempting to run the operator on k8s 1.14 or earlier will fail with an error:
kubernetes 1.15.0 or above required.@avestuk has agreed to test across the supported platforms prior to merge.