Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Use seek_realtime when saving journal data #1284

Merged

Conversation

vojtechtrefny
Copy link
Member

@vojtechtrefny vojtechtrefny commented Jun 10, 2024

See also #1283

For some reason seek_monotonic fails to seek resulting in saving
the entire journal for every test case when writing the flight
recorder log.
We are not using this log file that often and we can save a lot
of space by compressing it.
@vojtechtrefny vojtechtrefny changed the title Master fix flight recorder tests: Use seek_realtime when saving journal data Jun 10, 2024
Copy link
Member

@tbzatek tbzatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@vojtechtrefny vojtechtrefny merged commit 58555e4 into storaged-project:master Jun 10, 2024
14 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants