Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: document NULL return for udisks_client_get_partition_table #1258

Merged
merged 1 commit into from
Feb 26, 2024
Merged

client: document NULL return for udisks_client_get_partition_table #1258

merged 1 commit into from
Feb 26, 2024

Conversation

FineFindus
Copy link
Contributor

Documents that udisks_client_get_partition_table can return NULL. This is similar to functions like udisks_client_get_drive_for_block which document the possible NULL returns.

@StorageGhoul
Copy link

Can one of the admins verify this patch?

@tbzatek
Copy link
Member

tbzatek commented Feb 26, 2024

Jenkins, ok to test

tbzatek
tbzatek approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@tbzatek tbzatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@tbzatek tbzatek merged commit 8eb7f17 into storaged-project:master Feb 26, 2024
17 of 18 checks passed
@FineFindus FineFindus deleted the fix/partition-table-null branch February 26, 2024 15:58
FineFindus added a commit to FineFindus/udisks-rs that referenced this pull request Feb 29, 2024
@FineFindus
chore(client): remove todo
8043754 
Fixed storaged-project/udisks#1258.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbzatek tbzatek tbzatek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FineFindus @StorageGhoul @tbzatek